Handle connection_init and connection_terminate #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a ton for the PR @fdev! I'd love to merge this in. Would you mind adding some unit tests as well? |
|
Thanks for the quick response @jaydenwindle. I have added tests and squashed a bug in the process. By the way, I'm getting warnings about the |
|
@jaydenwindle Why is this PR not being merged? I am suffering from that timeout problem |
|
Is anyone watching this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Apollo Client (specifically
subscriptions-transport-ws) the websocket client expects either aconnection_ackorconnection_errorresponse from the server after sending the initialconnection_initmessage.Currently,
graphene-subscriptionsjust ignores these message types which causes the client to never emitconnectedevents and may cause amaxConnectTimetrigger to be performed.