Skip to content

Commit

Permalink
Remove Head.rewind() in withGraphQLApp.
Browse files Browse the repository at this point in the history
This has apparently been unnecessary since [email protected]: vercel/next.js#9326 (comment)
  • Loading branch information
jaydenseric committed Feb 25, 2020
1 parent e46f3be commit 142f1a2
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Removed the now redundant [`eslint-plugin-import-order-alphabetical`](https://npm.im/eslint-plugin-import-order-alphabetical) dev dependency.
- Stop using [`husky`](https://npm.im/husky) and [`lint-staged`](https://npm.im/lint-staged).
- Use strict mode for scripts.
- Removed the [`next`](https://npm.im/next) dev dependency and `Head.rewind()` in `withGraphQLApp`, as this has [apparently been unnecessary since `[email protected]`](https://github.com/zeit/next.js/issues/9326#issuecomment-590702751).

## 5.1.0

Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"eslint-plugin-react-hooks": "^2.4.0",
"graphql-react": "^9.1.0",
"jsdoc-md": "^5.0.1",
"next": "^9.2.2",
"prettier": "^1.18.2",
"react": "^16.8.6"
},
Expand Down
3 changes: 0 additions & 3 deletions src/universal/withGraphQLApp.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { ssr } from 'graphql-react/server'
// pointing to an empty decoy for the browser bundle.
// eslint-disable-next-line node/no-missing-import
import { LinkHeader } from 'next-graphql-react/server/LinkHeader'
import Head from 'next/head'
import React from 'react'

/**
Expand Down Expand Up @@ -127,8 +126,6 @@ export const withGraphQLApp = App =>
ssr(graphql, <context.AppTree {...props} graphql={graphql} />)
.catch(console.error)
.then(() => {
Head.rewind()

const responseLinkHeader = new LinkHeader(
// Might be undefined.
context.ctx.res.getHeader('Link')
Expand Down

0 comments on commit 142f1a2

Please sign in to comment.