Add tests to demonstrate client abort #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydenseric
reviewed
Jun 19, 2018
| @@ -73,6 +73,8 @@ | |||
| "watch": "watch 'npm test --silent' src --interval 1", | |||
| "test": "FORCE_COLOR=1 TAP_COLORS=1 npm-run-all build:clean -p build:mjs build:js -s build:prettier -p lint:* tap:* -c --aggregate-output --silent", | |||
| "prepublishOnly": "npm test", | |||
| "test:js": "FORCE_COLOR=1 TAP_COLORS=1 npm-run-all build:clean build:js tap:js", | |||
| "test:mjs": "FORCE_COLOR=1 TAP_COLORS=1 npm-run-all build:clean build:mjs tap:mjs", | |||
There was a problem hiding this comment.
I'm not following the reasons for this change, but I have a new approach to scripts that I'll copy over soon from graphql-api-koa and graphql-react: https://github.com/jaydenseric/graphql-api-koa/blob/master/package.json#L58. It leverages prepare so people can npm install a git url to use forks and even specific commits.
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79.
This PR includes tests from #81 which demonstrate a client abort, as requested in #77 and #83. Note that because
tapruns the sub-tests sequentially (even they are instantiated in parallel andawaited inside aPromise.all()) this actually exposes a bug where apollo-upload-server can hang indefinitely. This is a separate issue from #77, and is addressed by #81.