Fix #123 - request paused on exit #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that subsequent operations which have the effect of pausing the request are already queued for this event frame. This rux adds setImmediate to push stream resumption to the next frame. In the future, we should run tests with a small payload AND one that exceeds the maximum TCP packet size limit and node internal buffer. This would help identify this kind of bug.
jaydenseric
requested changes
Nov 16, 2018
|
Added! (Assuming this will be published in a patch-level release.) |
jaydenseric
approved these changes
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that subsequent operations which have the effect of pausing the request are already queued for this event frame. This fix adds setImmediate to push stream resumption to the next frame.
In the future, we should run tests with a small payload AND one that exceeds the maximum TCP packet size limit and node internal buffer. This would help identify this kind of bug.