-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Blob type #2
Conversation
Thanks for the PR 🙂 A heads-up that I won't have the time to properly review this for at least the next few days. A brief, but related conversation: jaydenseric/apollo-upload-client#28 (comment). |
ie11 and edge can't create file with new File(['test file'], 'test.txt') my english is not good, sorry 🙁 |
That's ok about the english 🙂 Because blobs are a little different to files this PR needs to be closely reviewed and tested across 4 related packages ( |
I got it. |
It seems I need Blob support too. I'm building a File object manually (from data URI after cropping an image), not using one from the File API. Here's a minimal case that illustrates the problem. I found that the following seems to work in Chrome but not in Webkit:
In Webkit, the 'foo' part body is empty. However this works in both (using Blob instead of file):
|
I've been crazy busy with gen 2 uploads, which are are now in alpha. Other than preparing stable releases, this, along with #3 is my next priority. |
Thanks for looking into this, I tried to merge this before #5 so you would be included in the contributors list, but there were too many conflicts with the current |
IE11 not support new File(). must use Blob instead.