Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

limactl ls <vm> returns 1 when the <vm> doesn't exist #31

Closed
jay7x opened this issue Jun 2, 2024 · 0 comments · Fixed by #32
Closed

limactl ls <vm> returns 1 when the <vm> doesn't exist #31

jay7x opened this issue Jun 2, 2024 · 0 comments · Fixed by #32
Assignees
@jay7x
Labels
bug Something isn't working

Comments

@jay7x
Copy link
Owner

jay7x commented Jun 2, 2024

Starting from lima 22.0 (I guess) limactl ls <vm> returns 1 when the doesn't exist. That breaks many plans because list and status tasks fails instead of returning empty result.
@jay7x jay7x added the bug Something isn't working label Jun 2, 2024
jay7x added a commit that referenced this issue Jun 2, 2024
@jay7x
Do not check limactl list exit code
fbf00e6 
Starting from lima v0.22.0 (I guess) `limactl ls <vm>` returns 1, when
the <vm> doesn't exist. That breaks many plans because list and status
tasks fails instead of returning empty result.

This commit removes the `limactl list` return code check. Maybe later
we can improve it.

Fixes #31
@jay7x jay7x mentioned this issue Jun 2, 2024
Merged
@jay7x jay7x closed this as completed in #32 Jun 2, 2024
jay7x added a commit that referenced this issue Jun 2, 2024
@jay7x
Merge pull request #32 from jay7x/gh-31
52b3633 
Do not check `limactl list` exit code
@jay7x jay7x self-assigned this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jay7x jay7x

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not check limactl list exit code jay7x/puppet-lima
1 participant
@jay7x