sharding cleanup: use inline checks for unimplemented and auto #24470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2810
approved these changes
Oct 22, 2024
jakevdp
force-pushed
the
is-unspecified
branch
from
be7ff61 to
d580998
Compare
jakevdp
force-pushed
the
is-unspecified
branch
2 times, most recently
from
ce13a14 to
fce9574
Compare
jakevdp
changed the title
yashk2810
approved these changes
Oct 23, 2024
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Oct 24, 2024
This will be removed in jax-ml/jax#24470 PiperOrigin-RevId: 689467667
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Oct 25, 2024
This will be removed in jax-ml/jax#24470 PiperOrigin-RevId: 689540255
copybara-service bot
pushed a commit
to jax-ml/oryx
that referenced
this pull request
Oct 25, 2024
This will be removed in jax-ml/jax#24470 PiperOrigin-RevId: 689644327
jakevdp
force-pushed
the
is-unspecified
branch
from
fce9574 to
8948e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #24465 (comment)