[Pallas] Simplify sign and erf_inv tests #23814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_677019633
branch
8 times, most recently
from
71e25a6 to
84077a3
Compare
Removed the method to locally enabling x64 using:
```python
with contextlib.ExitStack() as stack:
if jnp.dtype(dtype).itemsize == 8:
stack.enter_context(config.enable_x64(True))
```
This is because we can determine whether a test is running in x64 environment by checking the value of `jax.config.x64_enabled`. There is no need to locally enabling x64.
PiperOrigin-RevId: 677865574
copybara-service
bot
force-pushed
the
test_677019633
branch
from
84077a3 to
93203c7
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…nvironments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…nvironments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
…nvironments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
…nvironments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
…nvironments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
…nments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
…nments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 679307748
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 8, 2024
…nments This PR is similar to #23814. Background: We run tests on both 32-bit and 64-bit environments. Currently, when the tests encounters 64-bit dtypes on 32-bit environments, it enters into a local 64-bit environment using `stack.enter_context(config.enable_x64(True))`. This is not necessary since we also run the same tests on 64-bit environments. This PR makes those test skipped on 32-bit environments. PiperOrigin-RevId: 683405197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Pallas] Simplify sign and erf_inv tests
Removed the method to locally enabling x64 using:
This is because we can determine whether a test is running in x64 environment by checking the value of
jax.config.x64_enabled. There is no need to locally enabling x64.