Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added device kwarg to jnp.linspace and jnp.asarray #22080

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Added device kwarg to jnp.linspace and jnp.asarray #22080

merged 1 commit into from
Jul 26, 2024

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jun 25, 2024 •
edited
Loading

Description:

  • Added device kwarg to jnp.linspace and jnp.asarray
  • Updated tests

TODO:

  • remove linspace from array_api submodule
  • remove asarray from array_api submodule

Based on #21980 (once that PR is merged, I'll rebase this one)

Related to #21088

@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch from 1e56f62 to 8d5cc7f Compare June 25, 2024 08:48
@vfdev-5 vfdev-5 mentioned this pull request Jun 25, 2024
Merged
jakevdp
jakevdp requested changes Jun 25, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
@jakevdp jakevdp self-assigned this Jun 25, 2024
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch 3 times, most recently from d400aec to e0fa3ca Compare June 28, 2024 11:48
@vfdev-5 vfdev-5 marked this pull request as ready for review June 28, 2024 11:49
@vfdev-5 vfdev-5 changed the title Added device kwarg to jnp.linspace and jnp.array Added device kwarg to jnp.linspace, jnp.array and jnp.asarray Jun 28, 2024
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch from e0fa3ca to db2e347 Compare June 28, 2024 12:18
@vfdev-5 vfdev-5 requested a review from jakevdp June 28, 2024 12:19
jakevdp
jakevdp reviewed Jun 28, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
tests/lax_numpy_test.py Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch 3 times, most recently from de8d467 to e305a64 Compare July 10, 2024 05:19
@vfdev-5 vfdev-5 mentioned this pull request Jul 10, 2024
Open
yashk2810
yashk2810 reviewed Jul 10, 2024
View reviewed changes
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 changed the title Added device kwarg to jnp.linspace, jnp.array and jnp.asarray Added device kwarg to jnp.linspace and jnp.asarray Jul 25, 2024
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch 2 times, most recently from a98ff0d to fc78d13 Compare July 25, 2024 19:32
@vfdev-5 vfdev-5 requested a review from jakevdp July 25, 2024 19:34
jakevdp
jakevdp requested changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close! Thanks for working on this!

jax/_src/numpy/lax_numpy.py Outdated Show resolved Hide resolved
tests/lax_numpy_test.py Outdated Show resolved Hide resolved
tests/lax_numpy_test.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch 2 times, most recently from eeb71ef to 06d916e Compare July 25, 2024 22:04
jakevdp
jakevdp reviewed Jul 25, 2024
View reviewed changes
tests/lax_numpy_test.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 force-pushed the add-device-kwarg-linspace-array branch from 06d916e to 76d61f9 Compare July 25, 2024 22:36
jakevdp
jakevdp approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@jakevdp jakevdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@google-ml-butler google-ml-butler bot added the pull ready Ready for copybara import and testing label Jul 25, 2024
@copybara-service copybara-service bot merged commit aeff5b6 into jax-ml:main Jul 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashk2810 yashk2810 yashk2810 left review comments

@jakevdp jakevdp jakevdp approved these changes

Assignees

@jakevdp jakevdp

Labels
pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @jakevdp @yashk2810 @kokoro-team