-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added trace alias to jnp.linalg #21442
Added trace alias to jnp.linalg #21442
Conversation
Instead of adding an alias in the linalg source file, could we just add a direct import of the source of |
I have no strong opinion on the approach. Yes, we can do that as well. In the current approach we sort of hidden that detail into to the |
02b56d9
to
98ffb95
Compare
98ffb95
to
733117a
Compare
733117a
to
63b6851
Compare
63b6851
to
0030d22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just realized that this new function is missing from the docs here: https://github.com/google/jax/blob/main/docs/jax.scipy.rst#jaxscipylinalg
I should be missing something as I'm not sure to understand your point here. As far as I understand, there is no |
Sorry, I meant to point to the numpy docs: https://github.com/google/jax/blob/main/docs/jax.numpy.rst#jaxnumpylinalg We need to add the function to that list, or it won't show up in the API docs on the website. |
Related to jax-ml#21088
0030d22
to
d2185d3
Compare
Related to #21088
cc @Micky774