Add new cumulative_sum function to numpy and array_api namespaces #20756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Micky774
force-pushed
the
array-api-cumulative-sum
branch
from
1bfd146 to
b6f48c0
Compare
Micky774
force-pushed
the
array-api-cumulative-sum
branch
from
b6f48c0 to
f5fa5c1
Compare
jakevdp
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Thanks for working on this!
Also please add the new function to the docs by listing it here: https://github.com/google/jax/blob/main/docs/jax.numpy.rst
Micky774
force-pushed
the
array-api-cumulative-sum
branch
from
f5fa5c1 to
10d2ede
Compare
jakevdp
reviewed
Apr 16, 2024
Micky774
force-pushed
the
array-api-cumulative-sum
branch
3 times, most recently
from
f111aa3 to
ff1a526
Compare
jakevdp
reviewed
Apr 16, 2024
Micky774
force-pushed
the
array-api-cumulative-sum
branch
from
ff1a526 to
ceeb975
Compare
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
reviewed
Apr 16, 2024
| if (dtype is None and kind in {'i', 'u'} | ||
| and x.dtype.itemsize*8 < int(config.default_dtype_bits.value)): | ||
| dtype = dtypes.canonicalize_dtype(dtypes._default_types[kind]) | ||
| x = x.astype(dtype=dtype or x.dtype) |
There was a problem hiding this comment.
Side-note: referencing the discussion in #20195, this is an example of a place where we wouldn't want copy in astype to default to True!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #20200
Adds a new
cumulative_sumfunction to thejax.numpyandjax.experimental.array_apinamespaces in compliance with the array API 2023 standard.