Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lax_test: make ComplexPlane sign tests compatible with numpy 2 #20322

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Mar 19, 2024

The behavior of numpy.sign on complex numbers changed from 1.X to 2.X; jax currently matches the 2.X behavior.

Part of #19246

@jakevdp jakevdp requested a review from pearu March 19, 2024 18:05
@jakevdp jakevdp self-assigned this Mar 19, 2024
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Mar 19, 2024
@jakevdp
Copy link
Collaborator Author

jakevdp commented Mar 19, 2024

Failure is unrelated and should be fixed by #20323

Copy link
Collaborator

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @jakevdp!

@copybara-service copybara-service bot merged commit 6fa75aa into jax-ml:main Mar 19, 2024
7 of 13 checks passed
@jakevdp jakevdp deleted the complex-plane-numpy2 branch March 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants