Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test of jnp.unique compatible with NumPy 2.0 #19703

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Feb 7, 2024

NumPy 2.0 added OverflowErrors on array creation if the input is not representable under the requested dtype, but explicitly using array(value).astype(dtype) will silently wrap the value.

Part of #19246

@jakevdp jakevdp requested a review from yashk2810 February 7, 2024 20:46
@jakevdp jakevdp self-assigned this Feb 7, 2024
@jakevdp jakevdp added the pull ready Ready for copybara import and testing label Feb 7, 2024
@copybara-service copybara-service bot merged commit 1e31c15 into jax-ml:main Feb 8, 2024
13 checks passed
@jakevdp jakevdp deleted the unique-test branch February 8, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant