Fix type annotation for array_api.broadcast_to
#19499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jakevdp
requested changes
Jan 24, 2024
| """Broadcasts an array to a specified shape.""" | ||
| return jax.numpy.broadcast_to(x, shape=shape) | ||
| def broadcast_to(x: Array, /, shape: tuple[int, ...]) -> Array: |
There was a problem hiding this comment.
The annotation change looks good, but we should move the function definition back to its original line.
|
Hi - let me know if you want to finish this PR! If not I'll make the change you noted separately. |
Signed-off-by: nstarman <[email protected]>
nstarman
force-pushed
the
array_api-broadcast_to-type-hint
branch
from
4993e72 to
b9f2857
Compare
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the shape annotation isn't correct.