jnp.sign: use x/abs(x) for complex arguments #19390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
copybara-service bot
pushed a commit
to google-deepmind/dm-haiku
that referenced
this pull request
Jan 17, 2024
The implementation of jnp.sign changed in jax-ml/jax#19390 PiperOrigin-RevId: 599194751
copybara-service bot
pushed a commit
to google-deepmind/dm-haiku
that referenced
this pull request
Jan 17, 2024
The implementation of jnp.sign changed in jax-ml/jax#19390 PiperOrigin-RevId: 599194751
copybara-service bot
pushed a commit
to google-deepmind/dm-haiku
that referenced
this pull request
Jan 17, 2024
The implementation of jnp.sign changed in jax-ml/jax#19390 PiperOrigin-RevId: 599205731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #19246
Follows NumPy change in numpy/numpy#25441
We'll need to rebase on #19389 to fix some test failures.