Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test jax.extend custom PRNG construction round trip #17988

Merged
merged 1 commit into from
Oct 6, 2023
Merged

test jax.extend custom PRNG construction round trip #17988

merged 1 commit into from
Oct 6, 2023

Conversation

froystig
Copy link
Member

@froystig froystig commented Oct 6, 2023

Test that the key de/construction round trip introduced in #17983 also works with custom PRNG schemes defined via jax.extend.random.

@froystig froystig requested a review from jakevdp October 6, 2023 18:04
@froystig froystig self-assigned this Oct 6, 2023
@froystig froystig changed the title test custom PRNG construction round trip test jax.extend custom PRNG construction round trip Oct 6, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Oct 6, 2023
copybara-service bot pushed a commit that referenced this pull request Oct 6, 2023
Make jax._src.typing.DTypeLike more strictly defined
24fba7b 
This is in preparation for exporting this to `jax.typing.DTypeLike`. We want to make certain it's a meaningful type before exporting, because currently it is effectively just Any.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17988 from froystig:rng-spec-jex 7b831ba
PiperOrigin-RevId: 571090887
@copybara-service copybara-service bot mentioned this pull request Oct 6, 2023
Merged
@copybara-service copybara-service bot merged commit 5ac2513 into jax-ml:main Oct 6, 2023
7 checks passed
@froystig froystig deleted the rng-spec-jex branch October 6, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakevdp jakevdp jakevdp approved these changes

Assignees

@froystig froystig

Labels
kokoro:force-run pull ready Ready for copybara import and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@froystig @jakevdp