MAINT Clean up leftover Array = Any aliases in jax/_src/**.py
#17760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superbobry
force-pushed
the
array-any
branch
from
737e6a2 to
68f0ab1
Compare
|
If we're going to land this, I think we should fix rather than silence the errors as part of this PR. |
|
I fixed two out of three errors. The remaining one is tricky, because it overlaps dynamic shapes and ragged tensors and is not documented enough for me to figure out what the "right" (intended) types are. |
jakevdp
requested changes
Sep 26, 2023
superbobry
force-pushed
the
array-any
branch
from
efbbe2d to
8ca39a1
Compare
jakevdp
reviewed
Sep 26, 2023
superbobry
force-pushed
the
array-any
branch
from
8ca39a1 to
86f6f07
Compare
jakevdp
approved these changes
Sep 27, 2023
google-ml-butler
bot
added
kokoro:force-run
pull ready
jakevdp
requested changes
Sep 28, 2023
superbobry
force-pushed
the
array-any
branch
from
e6ad41c to
d5527df
Compare
jakevdp
approved these changes
Sep 28, 2023
superbobry
force-pushed
the
array-any
branch
5 times, most recently
from
ce86a3c to
5c8586e
Compare
I had to revert to using `Any` for `RaggedAxis.ragged_axes` because pytype found more latent type errors, which require the understanding of ragedness and dynamic shapes internals to fix properly.
copybara-service bot
pushed a commit
to google-deepmind/clrs
that referenced
this pull request
Oct 1, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 569885017
copybara-service bot
pushed a commit
to google-deepmind/clrs
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 569885017
copybara-service bot
pushed a commit
to google-deepmind/clrs
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 569979327
copybara-service bot
pushed a commit
to google-deepmind/clrs
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 569979327
copybara-service bot
pushed a commit
to google-deepmind/clrs
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 569994709
copybara-service bot
pushed a commit
to google-research/scenic
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 570088709
copybara-service bot
pushed a commit
to google-research/scenic
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 570090425
copybara-service bot
pushed a commit
to google-research/scenic
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 570090425
copybara-service bot
pushed a commit
to google-research/scenic
that referenced
this pull request
Oct 2, 2023
… in JAX Some JAX internal used Any instead of Array or in their type annotations. jax-ml/jax#17760 changed these to alias jax.Array and uncovered type errors fixed here. PiperOrigin-RevId: 570128353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemingly minor change uncovered a few inconsistencies in existing code. I silenced the new type errors via ``type: ignore` and added a TODO to investigate later.