Skip to content

Commit

Permalink
Reenable some tests disabled in the past because of an LLVM bug.
Browse files Browse the repository at this point in the history
The issue no longer reproduces at head.

PiperOrigin-RevId: 480505525
  • Loading branch information
hawkinsp authored and jax authors committed Oct 12, 2022
1 parent 012398b commit 9bb2c99
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
6 changes: 0 additions & 6 deletions tests/lax_autodiff_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -367,12 +367,6 @@ def testConvGeneralDilatedGrad(self, lhs_shape, rhs_shape, dtype, strides,
if dtype == np.float16:
raise SkipTest("float16 numerical issues") # TODO(mattjj): resolve

if (jtu.device_under_test() == "cpu" and dtype == np.float64 and
lhs_shape == (1,1,6,7) and rhs_shape == (2,1,1,2) and strides == (2, 1)
and padding == ((0, -1), (0, 0)) and lhs_dil == (1, 1) and
rhs_dil == (1, 1)):
# TODO(b/173608403): reenable after LLVM fix.
raise SkipTest("Skipping test due to LLVM lowering bug")
rng = jtu.rand_default(self.rng())
tol = {dtypes.bfloat16: 1e-0, np.float16: 5e-1, np.float32: 1e-3}

Expand Down
4 changes: 0 additions & 4 deletions tests/lax_scipy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,6 @@ def testLogSumExpNans(self):
@jax.numpy_dtype_promotion('standard') # This test explicitly exercises dtype promotion
def testScipySpecialFun(self, scipy_op, lax_op, rng_factory, shapes, dtypes,
test_autodiff, nondiff_argnums):
if (jtu.device_under_test() == "cpu" and
(lax_op is lsp_special.gammainc or lax_op is lsp_special.gammaincc)):
# TODO(b/173608403): re-enable test when LLVM bug is fixed.
raise unittest.SkipTest("Skipping test due to LLVM lowering bug")
rng = rng_factory(self.rng())
args_maker = self._GetArgsMaker(rng, shapes, dtypes)
args = args_maker()
Expand Down

0 comments on commit 9bb2c99

Please sign in to comment.