🔥 Avoid setting/imposing TRACE level for everyone #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staying as far as humanly possible from any controversial situation
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 89.41% 89.40% -0.01%
==========================================
Files 11 11
Lines 1200 1199 -1
==========================================
- Hits 1073 1072 -1
Misses 127 127
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staying as far as humanly possible from any controversial situation.
cf. https://docs.python.org/3/howto/logging.html#custom-levels
A quick search through GH shows that
TRACEis often assigned toint:5but it's not always the case. So to avoid the same situation in another place, I am removing the global assignment.