Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish translation #17

Open
alanverdugo opened this issue Jan 26, 2021 · 30 comments
Open

Spanish translation #17

alanverdugo opened this issue Jan 26, 2021 · 30 comments

Comments

@alanverdugo
Copy link
Contributor

Hi, I would like to help the site by translating its contents to Spanish, since I am a native speaker.

Please let me know if this is fine for you, and what would be needed.

I suppose I can just translate the .md files and put them in a new directory under src, just like the French translation: https://github.com/jawache/principles-green/tree/master/src/fr-fr

Please let me know if anything else is needed. Thanks.
@sebasrivera96
Copy link
Contributor

Hi @alanverdugo,

this is a great idea! Not sure if you've contacted someone else to follow up on this. I'm down to help you with the translation to Spanish.

@jawache any thoughts on this?

@alanverdugo
Copy link
Contributor Author

Hey @sebasrivera96 , I haven't been in contact with anybody else, but I am still willing to help!

@jawache
Copy link
Owner

jawache commented Mar 18, 2021

Hi @alanverdugo and @sebasrivera96 apologies for the delay - I was just making sure the English version was up to date first! Yes, that would be amazing. @pierlag was the person who created the french version in case there are questions about structure.

@sebasrivera96
Copy link
Contributor

Thank you @jawache. IMO we can fork this repo and start working on the translation with the content published at the moment.

@alanverdugo if you agree, you can fork the repo and we split up the content to translate it. Otherwise, we could use a fork I already created and start the translation there. Both work for me. Please let me know your thoughts :)

@alanverdugo
Copy link
Contributor Author

Hi @sebasrivera96 , sounds good! :)

I can create my own fork, so let's just agree on which files each one of us will translate.

I see 12 .md files in https://github.com/jawache/principles-green/tree/master/src/fr-fr , so we can take 6 files each.

For example, this could be an option:

@sebasrivera96 :

  1. index.md
  2. principles/carbon-intensity.md
  3. principles/carbon.md
  4. principles/demand-shaping.md
  5. principles/electricity.md
  6. principles/embodied-carbon.md

So I would take the rest:

  1. principles/energy-proportionality.md
  2. principles/measurement.md
  3. principles/networking.md
  4. principles/applied/microservices.md
  5. principles/applied/n-tier.md
  6. principles/applied/web-queue-worker.md

Let me know what you think, if there are any other files that need to be translated, or if you want to switch files. Thanks!

@sebasrivera96
Copy link
Contributor

Would it be ok for you if we swap 5 and 6? So this would be the list:

@sebasrivera96:

  1. index.md
  2. principles/carbon-intensity.md
  3. principles/carbon.md
  4. principles/demand-shaping.md
  5. principles/applied/n-tier.md
  6. principles/applied/web-queue-worker.md

@alanverdugo:

  1. principles/energy-proportionality.md
  2. principles/measurement.md
  3. principles/networking.md
  4. principles/applied/microservices.md
  5. principles/electricity.md
  6. principles/embodied-carbon.md

Also, could you add me as a Contributor to your fork once you create it? I can then create my own branch from your master and start working from there.

Let me know your thoughts, Alan!

@alanverdugo
Copy link
Contributor Author

Hi @sebasrivera96 ! Sounds good!
I've created a fork and invited you as a collaborator. Please let me know if anything else is needed :)
If not, I'll start with the files you assigned to me ASAP.

@sebasrivera96
Copy link
Contributor

Sounds like a plan! I'll start working on the translation this weekend too.

Thank you!

@alanverdugo
Copy link
Contributor Author

Hello @sebasrivera96 !

I've completed the translations for the files you assigned to me. The translated files are in: https://github.com/alanverdugo/principles-green/tree/master/src/es

Please feel free to take a look and provide any feedback.

Note: I used "es" for the containing directory name based on the "IETF language tag" from https://en.wikipedia.org/wiki/Language_code#Common_schemes . This can be changed, of course.

Please let me know if anything else is needed. Thanks!

@ivantxu
Copy link
Contributor

ivantxu commented Apr 12, 2021 •
edited
Loading

Hi! Am I too late to help with this?

@sebasrivera96
Copy link
Contributor

Hi @alanverdugo!

Thanks for the heads up! I'm still working on my files. I'll read your's and provide feedback in case any modification is required.

Hey @ivantxu! You can send me an email and we can coordinate if you would like to help on the translation to Spanish ;)

[email protected]

@ivantxu
Copy link
Contributor

ivantxu commented Apr 13, 2021

Done!

@alanverdugo
Copy link
Contributor Author

Hello @sebasrivera96 , @ivantxu

Just wondering if you need any help with the translation(s).

Please let me know, thanks!

@Felivel
Copy link

Felivel commented Jul 26, 2021

@alanverdugo @sebasrivera96 @ivantxu I am also available to work on the Spanish translation?

@alanverdugo
Copy link
Contributor Author

Hi @Felivel !
I haven't received any more info from @sebasrivera96 or @ivantxu , but I think they are working on translating the following files:

index.md
principles/carbon-intensity.md
principles/carbon.md
principles/demand-shaping.md
principles/applied/n-tier.md
principles/applied/web-queue-worker.md

If you want to help, I can add you as a collaborator to my fork and then you could translate some of those files, and upload those translations to: https://github.com/alanverdugo/principles-green/tree/master/src/es

Let me know! Thanks!

@ivantxu
Copy link
Contributor

ivantxu commented Aug 1, 2021 via email

@alanverdugo
Copy link
Contributor Author

HI @ivantxu , no problem!

Once you have the PR I can review them as well, if you like. Maybe @Felivel can also help us with the review since he offered to help.

Thanks!

@sebasrivera96
Copy link
Contributor

sebasrivera96 commented Aug 2, 2021 via email

@alanverdugo
Copy link
Contributor Author

Hi @sebasrivera96 ! 😃 Yes, you can push it to my fork and then I can create a PR in order to merge it to this repository.
Thanks!

@sebasrivera96
Copy link
Contributor

Hello @alanverdugo, I'm done with the translations from the applied dir. I already created a Pull Request directly to the main repo. If you would like me to push directly into master of your forked repo, let me know and I can do that too.

Also, @ivantxu have you pushed your files to any repo? What's the status on your end?

@ivantxu
Copy link
Contributor

ivantxu commented Aug 21, 2021 via email

@alanverdugo
Copy link
Contributor Author

Hi everybody! I just created a PR that includes @ivantxu 's translations, and mine.

Here it is: #32

@jawache
Copy link
Owner

jawache commented Aug 22, 2021

Hi all, thank you so much for doing this. It's all been merged and the website updated!

@alanverdugo
Copy link
Contributor Author

HI again @jawache , thanks for accepting both pull requests and updating the site! :)

However, I believe we also need to update the top-right button in the site (that displays either "EN" or "FR") in order to somehow add Spanish.

To be honest, I am not sure how to do that since I am not a front-end developer, but let me know if I should open a new issue for that, or if there is something else I can do to help. Thanks!

@ivantxu
Copy link
Contributor

ivantxu commented Aug 23, 2021

I found some small issues with the translations, for example this link doesn't have proper styling. I could take a look but it is possible that it would have to wait for next week, because this week I have to travel. I could also take a look at linking the Spanish translation on the header, but wouldn't link it until these issues are fixed.

@jawache
Copy link
Owner

jawache commented Aug 23, 2021 via email

@sebasrivera96
Copy link
Contributor

sebasrivera96 commented Aug 25, 2021 •
edited
Loading

Hello everyone! Thank you for your time on doing this work 😄

@ivantxu I found the commit for the case when the French toggle button was introduced. I'm on the same boat as @alanverdugo 😸 ... also not a Front-end developer but I'll take a look to see if the fix could be something trivial.

@lynxlynxlynx lynxlynxlynx mentioned this issue Nov 9, 2021
Open
@ivantxu
Copy link
Contributor

ivantxu commented Dec 1, 2021

Hi all! 👋

The last months have been a bit crazy, but I finally got some time to fix the template issues that were happening in the Spanish translations and also added the new link to the header. There is an open PR #36 .

Also, @jawache regarding the talks I'm interested, I'm planning to do a small talk about the topic in my company and would like to collaborate after that if possible. Github has censored your email and is displayed as asterisks, how could I get in touch with you?

@sebasrivera96
Copy link
Contributor

sebasrivera96 commented Dec 1, 2021 via email

@alanverdugo
Copy link
Contributor Author

Hey guys how have you been? is there any blocker for the Spanish translation?

I am not sure what is left to do, so just please let me know if you need help. Thanks. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jawache @Felivel @ivantxu @sebasrivera96 @alanverdugo