Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
minor symfony#20090 [Security] Authenticator methods description (smn…
…andre) This PR was submitted for the 7.1 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- [Security] Authenticator methods description At first i just wanted to reword this sentence i found missleading.. in the [Custom Authenticator](https://symfony.com/doc/current/security/custom_authenticator.html) page. > If ``null`` is returned, the request continues like normal (i.e. the controller matching the login route is called). I think it should be: ```diff - (i.e. the controller matching the login route is called) + (i.e. the controller matching the current route is called) ``` Because it _can_ be the login route for _some_ Authenticators, but it's not for stateless requests, Header tokens, remember me... I then realize the "if / if" was the reason I found things a bit unclear at first sight. ``` onAuthenticationSuccess(Request $request, ...) If the user is authenticated, (...) If ``null`` is returned, (...) ``` I read this as some sort of "if / else" ... but the first "if" englobes the whole paragraph (it's true again in the second one). So i tried to rewrite a bit (using the docblocks from the [AuthenticatorInterface](https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Security/Http/Authenticator/AuthenticatorInterface.php) as inspiration) Commits ------- 236e419 [Security] Authenticator methods description
- Loading branch information