Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessBasic getTempUrlPrefix should return path w/o http://hostname #90

Closed
wants to merge 1 commit into from

Conversation

eitan101
Copy link

StoredObject.getTempGetUrl doesn't work for AccessBasic since the signature is calculated according to absolute path (http://hostname/v1/account) and not relative path (/v1/account) as explained here and as done in AccessTenant.

@effi-ofer
Copy link
Contributor

Hey Eitan, I would like to take a look at your submission, but before I do so can you please add the following text, and sign it, to your submission as a comment? This is the same text used in the Linux Kernel community. By adding this comment, you tell the community that you wrote the code you are contributing, or you have the right to pass on the code that you are contributing.
Thanks!

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the Apache License 2.0; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

DCO 1.1 Signed-off-by: enter your name

@springhow
Copy link

Is this going to be fixed any time soon?

@ferrys ferrys closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants