Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Conversions #78

Merged
merged 3 commits into from
Jul 20, 2021
Merged

Type Conversions #78

merged 3 commits into from
Jul 20, 2021

Conversation

Arthur-Gyulabyan
Copy link
Contributor

Translated article of "Type Conversion" section.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 17, 2021 18:41
@javascript-translate-bot javascript-translate-bot mentioned this pull request Jul 17, 2021
Open
@bugron
Copy link
Contributor

bugron commented Jul 19, 2021

Thanks for the PR. I'll review it today.

bugron
bugron requested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos to fix otherwise looks great!

1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/07-type-conversions/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Arthur-Gyulabyan
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 20, 2021 06:53
@Arthur-Gyulabyan
Copy link
Contributor Author

Thanks for the review.

bugron
bugron approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugron bugron merged commit 8185a58 into javascript-tutorial:master Jul 20, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bugron bugron bugron approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arthur-Gyulabyan @bugron @javascript-translate-bot