Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data types #77

Merged
merged 8 commits into from
Jul 11, 2021
Merged

Data types #77

merged 8 commits into from
Jul 11, 2021

Conversation

Arthur-Gyulabyan
Copy link
Contributor

Data types section translated.

@javascript-translate-bot

Error: the article already has PR number in the Progress Issue #1, it's 77 ⁉️

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2021

CLA assistant check
All committers have signed the CLA.

@bugron
Copy link
Contributor

bugron commented Jul 10, 2021

@Arthur-Gyulabyan thanks for the PR. I'll review it soon. Keep up the good work!

@Arthur-Gyulabyan
Copy link
Contributor Author

@bugron thank you for response.

@bugron
Copy link
Contributor

bugron commented Jul 11, 2021

This looks great. I'll be reviewing your translations today. For future let's keep the one article - one PR principle.

@Arthur-Gyulabyan
Copy link
Contributor Author

Oh, sorry for that mistake. I'll follow the principle in further PRs.

Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arthur-Gyulabyan thanks again for the PR. I am amazed by the quality of the translation, really!
Please do not get discouraged by the number of comments! Except for those new line comments there are just a few things to address and we'll be ready to merge this.
Way to go!

1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/05-types/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/06-alert-prompt-confirm/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@Arthur-Gyulabyan
Copy link
Contributor Author

@bugron thank you for review! The issue with new lines occurred because of my editor's settings. I fixed it, so now everything is okay. I also fixed typos and other bugs.

@Arthur-Gyulabyan
Copy link
Contributor Author

/done

Copy link
Contributor

@bugron bugron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugron
Copy link
Contributor

bugron commented Jul 11, 2021

Thanks for your first PR! Merging and looking forward to your future contributions. 🎉🎉🎉

@bugron bugron merged commit df5f520 into javascript-tutorial:master Jul 11, 2021
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@javascript-translate-bot

Error: the article already translated in the Progress Issue #1 ⁉️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants