-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data types #77
Data types #77
Conversation
Error: the article already has PR number in the Progress Issue #1, it's 77 |
@Arthur-Gyulabyan thanks for the PR. I'll review it soon. Keep up the good work! |
@bugron thank you for response. |
This looks great. I'll be reviewing your translations today. For future let's keep the one article - one PR principle. |
Oh, sorry for that mistake. I'll follow the principle in further PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arthur-Gyulabyan thanks again for the PR. I am amazed by the quality of the translation, really!
Please do not get discouraged by the number of comments! Except for those new line comments there are just a few things to address and we'll be ready to merge this.
Way to go!
Please make the requested changes. After it, add a comment "/done". |
@bugron thank you for review! The issue with new lines occurred because of my editor's settings. I fixed it, so now everything is okay. I also fixed typos and other bugs. |
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your first PR! Merging and looking forward to your future contributions. 🎉🎉🎉 |
Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉 |
Error: the article already translated in the Progress Issue #1 |
Data types section translated.