Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focusing: focus/blur #527

Merged
merged 18 commits into from
Jul 20, 2021
Merged

Focusing: focus/blur #527

merged 18 commits into from
Jul 20, 2021

Conversation

j-llano
Copy link
Contributor

@j-llano j-llano commented Jul 14, 2021

No description provided.

@javascript-translate-bot javascript-translate-bot requested a review from a team July 14, 2021 10:37
@javascript-translate-bot
Copy link

Error: the article has another translator @fcojacuna in the Progress Issue #17.

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquinelio joaquinelio self-requested a review July 14, 2021 21:38
@joaquinelio joaquinelio self-assigned this Jul 14, 2021
joaquinelio
joaquinelio requested changes Jul 15, 2021
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello gracias me estaba sintiendo solo
Muy bueno
Algunos detalles que podes aceptar/ignorar,
Otros son por el raro "--", aceptalos o cambialos,
Me hiciste dudar con "utilicemolos", no se si "..mos-los" es el mismo caso que "..mos-nos", y como no sé, lo dejo. Deberia preguntar a fundeu.
Ah, y ponele aceite a la barra de espacio =)

2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/2-focus-blur/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio joaquinelio mentioned this pull request Jul 15, 2021
Open
@joaquinelio
Copy link
Member

Actualicé la lista del progress con tu usuario y pr,
estuvo inactiva por 4 meses

@joaquinelio joaquinelio removed their assignment Jul 15, 2021
j-llano and others added 15 commits July 20, 2021 11:59
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
2dca3d9 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
1e8bd06 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
a2a1fc1 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
bc3d8e5 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
6f883a9 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
acf277c 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
7c4c7af 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
98b83ff 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
126f7ff 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
1a50dae 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
f2a5a58 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
6c5617b 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
51a23bf 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Update 2-ui/4-forms-controls/2-focus-blur/article.md
7dd13fd 
Co-authored-by: joaquinelio <[email protected]>
@j-llano @joaquinelio
Apply suggestions from code review
a2719ed 
Co-authored-by: joaquinelio <[email protected]>
@j-llano
Copy link
Contributor Author

j-llano commented Jul 20, 2021

Tengo un poco de tiempo estos días así que intentaré traducir algo más.
pd: ya he echado la bronca a la barra de espacio.

@joaquinelio
Copy link
Member

el procedimiento esta en el issue #17
(se reclama articulo poniendo el coment en el #17, el bot aprueba si esta disponible)
y el resumen del ultimo progreso esta en mi ultimo coment ahi

veras en este PR que te salio esto
Error: the article has another translator @ in the Progress Issue #17.
porqye estaba reclamado por otro traductor

ignorando a don Bot, cambie a mano el issue 17 y puse tu nombre porque lleva 4 meses sin movimiento

plis revisa el #17
del ultimo coment podes elegir cualquier art SIN PR
y me avisas alli que borro el traductor porque ninguno es mas nuevo que 3 meses
O
si te animas podes hacer review de los 3 PR ya traducidos que estan pendientes

@joaquinelio
Copy link
Member

!Incorporado!

@j-llano plis lee lo que puse de los articulos ya traducidos

@joaquinelio joaquinelio merged commit 8f85dae into javascript-tutorial:master Jul 20, 2021
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

@joaquinelio
Copy link
Member

@j-llano
seguimos procedimiento y Don Bot se puso contento.

@joaquinelio
Copy link
Member

@j-llano
olvide verificar, online veo que tiene tasks
tambien pendientes de traduccion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j-llano @javascript-translate-bot @CLAassistant @joaquinelio