-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capturing groups #345
Capturing groups #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Por perezoso no verifiqué si hay version mas nueva con ingles
ni si hay más archivos por traducir que estos,
usualmente lo hago como parte del review
Que aburrido que es este tema.
Extraño a @cortizg...
No lo habia leido, me hubiera venido bien lo de matchall y lo de grupo con nombre
este es mi regexp para el api issue17:
/([[\sX]])\s([.+])\s?((http[.\S]+))\s?((@\w+))?\s?(#\d+)?/
bytheway,
en este proyecto no importa para los marcados [X],
pero por esto del formato del match deberias respetar los campos,
al poner 2 autores 2 pr, o cosas ssin los identif que separan los campos, el bot se confundiría.
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: joaquinelio <[email protected]>
Co-authored-by: joaquinelio <[email protected]>
Co-authored-by: joaquinelio <[email protected]>
Co-authored-by: joaquinelio <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otro cambio
@EzequielCaste "xxxobjetos/clases/regxx con nombre" |
ok lo dejamos como Grupo con nombre aunque me gusta más la otra forma...queda más profesional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listo
Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉 |
No description provided.