Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantifiers +, *, ? and {n} #297

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Quantifiers +, *, ? and {n} #297

merged 4 commits into from
Jul 13, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jul 12, 2020

traducción 9-09-q

@cortizg
traducción 9-09-q
3ad5d52 
fix typo

fix typo 2
@javascript-translate-bot javascript-translate-bot requested a review from a team July 12, 2020 03:26
joaquinelio
joaquinelio requested changes Jul 12, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No pienso salir de online para probar tus regexp...
sin eso, solo 2 cositas.

9-regular-expressions/09-regexp-quantifiers/article.md Outdated Show resolved Hide resolved
9-regular-expressions/09-regexp-quantifiers/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg
Copy link
Contributor Author

cortizg commented Jul 13, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 13, 2020 00:38
@cortizg cortizg requested review from joaquinelio and removed request for a team July 13, 2020 00:38
joaquinelio
joaquinelio approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vplentinax
vplentinax approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@joaquinelio joaquinelio merged commit da86cb5 into javascript-tutorial:master Jul 13, 2020
@joaquinelio
Copy link
Member

@ezzep66 @vplentinax
aviso nomás, no se si les pasó.
con el merge esperen el mensaje del bot,
me paso antes, el bot lo ignora si la diferencia es apenas una minuscula.,
aqui quizas por los símbolos.

@iliakan iliakan mentioned this pull request Jul 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplentinax vplentinax vplentinax approved these changes

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax