Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets and ranges [...] #296

Merged
merged 8 commits into from
Jul 13, 2020
Merged

Sets and ranges [...] #296

merged 8 commits into from
Jul 13, 2020

Conversation

cortizg
Copy link
Contributor

@cortizg cortizg commented Jul 11, 2020 •
edited
Loading

No description provided.

@cortizg
traduccion 9-08-sr
9ef788e 
typos

typo2

typo en código de ejemplo

typo3
@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 04:38
@iliakan iliakan mentioned this pull request Jul 11, 2020
Open
cortizg
cortizg commented Jul 11, 2020
View reviewed changes
Copy link
Contributor Author

@cortizg cortizg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

9-regular-expressions/08-regexp-character-sets-and-ranges/1-find-range-1/solution.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md

```js run
for(let i=0; i<'𝒳𝒴'.length; i++) {
for(let i = 0; i < '𝒳𝒴'.length; i++) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en las buenas prácticas los operadores deben de estar separados por un espacio, y linter tambièn lo recuerda.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y aquí?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya está listo

joaquinelio
joaquinelio requested changes Jul 11, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 pequeños...

9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@cortizg
Copy link
Contributor Author

cortizg commented Jul 11, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 11, 2020 14:28
@joaquinelio
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
1f62050 
…cle.md


esquiusmi...
aceptaste una bandera, pongo la otra
a desgano, pero para concordar.
joaquinelio
joaquinelio approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@joaquinelio joaquinelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cortizg
Copy link
Contributor Author

cortizg commented Jul 13, 2020

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 13, 2020 00:43
@cortizg cortizg requested review from vplentinax and removed request for a team July 13, 2020 00:43
vplentinax
vplentinax approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok..!

@joaquinelio joaquinelio merged commit e192dda into javascript-tutorial:master Jul 13, 2020
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplentinax vplentinax vplentinax approved these changes

@joaquinelio joaquinelio joaquinelio approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax