This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Use latest OpenJDK 11 EA build as boot JDK #165
Merged
kevinrushforth
merged 1 commit into
javafxports:develop
from
kevinrushforth:test-jdk-11
Aug 27, 2018
Merged
Use latest OpenJDK 11 EA build as boot JDK #165
kevinrushforth
merged 1 commit into
javafxports:develop
from
kevinrushforth:test-jdk-11
Aug 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrushforth
added
WIP
Work In Progress
Experiment
Experimental changes, not intented for merge
labels
Aug 23, 2018
If we want to get this in prior to the GA of OpenJDK 11, then all that is needed is to change the build logic in |
This is now ready for review. Here are the relevant portions of the logs showing that the builds are now using JDK 11. Note that this does not change the minimum required to build FX. That will be done separately after JDK 11 is released. Appveyor log (Windows) :
Travis log (Linux) :
Travis log (Mac) :
|
kevinrushforth
changed the title
[WIP] Test building with jdk 11
Use latest OpenJDK 11 EA build as boot JDK
Aug 25, 2018
kevinrushforth
added
enhancement
New feature or request
and removed
Experiment
Experimental changes, not intented for merge
WIP
Work In Progress
labels
Aug 25, 2018
LGTM. |
eugener
approved these changes
Aug 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the Travis and Appveyor scripts to download and use the latest OpenJDK 11 EA build.