Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Use latest OpenJDK 11 EA build as boot JDK #165

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Use latest OpenJDK 11 EA build as boot JDK #165

merged 1 commit into from
Aug 27, 2018

Conversation

kevinrushforth
Copy link
Collaborator

@kevinrushforth kevinrushforth commented Aug 23, 2018

Modifies the Travis and Appveyor scripts to download and use the latest OpenJDK 11 EA build.

@kevinrushforth kevinrushforth added WIP Work In Progress Experiment Experimental changes, not intented for merge labels Aug 23, 2018
@kevinrushforth kevinrushforth self-assigned this Aug 23, 2018
@kevinrushforth
Copy link
Collaborator Author

kevinrushforth commented Aug 23, 2018

If we want to get this in prior to the GA of OpenJDK 11, then all that is needed is to change the build logic in appveyor.yml to grab the latest EA build referenced by the http://jdk.java.net/11/ page rather than hard-coding build 27 (also, I will revert my temporary change that bumped the minimum boot JDK).

@kevinrushforth
Copy link
Collaborator Author

kevinrushforth commented Aug 25, 2018

This is now ready for review. Here are the relevant portions of the logs showing that the builds are now using JDK 11. Note that this does not change the minimum required to build FX. That will be done separately after JDK 11 is released.

Appveyor log (Windows) :

[00:02:41] JAVA_HOME: C:/jdk11
[00:02:41] JDK_HOME: C:/jdk11
[00:02:41] java.runtime.version: 11+28
[00:02:41] java version: 11
[00:02:41] java build number: 28
[00:02:41] jdk.runtime.version: 11+28
[00:02:41] jdk version: 11
[00:02:41] jdk build number: 28
[00:02:41] minimum jdk version: 10
[00:02:41] minimum jdk build number: 46

Travis log (Linux) :

JAVA_HOME: /home/travis/openjdk11
JDK_HOME: /home/travis/openjdk11
java.runtime.version: 11+28
java version: 11
java build number: 28
jdk.runtime.version: 11+28
jdk version: 11
jdk build number: 28
minimum jdk version: 10
minimum jdk build number: 46

Travis log (Mac) :

JAVA_HOME: /Users/travis/openjdk11
JDK_HOME: /Users/travis/openjdk11
java.runtime.version: 11+28
java version: 11
java build number: 28
jdk.runtime.version: 11+28
jdk version: 11
jdk build number: 28
minimum jdk version: 10
minimum jdk build number: 46

@kevinrushforth kevinrushforth changed the title [WIP] Test building with jdk 11 Use latest OpenJDK 11 EA build as boot JDK Aug 25, 2018
@kevinrushforth kevinrushforth added enhancement New feature or request and removed Experiment Experimental changes, not intented for merge WIP Work In Progress labels Aug 25, 2018
@kevinrushforth
Copy link
Collaborator Author

@brcolow @eugener Can you take a look?

@kevinrushforth kevinrushforth requested a review from eugener August 25, 2018 15:21
@brcolow
Copy link
Contributor

brcolow commented Aug 25, 2018

LGTM.

Copy link
Collaborator

@eugener eugener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinrushforth kevinrushforth merged commit 1739e24 into javafxports:develop Aug 27, 2018
@kevinrushforth kevinrushforth deleted the test-jdk-11 branch August 27, 2018 14:21
kevinrushforth added a commit that referenced this pull request Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants