-
Notifications
You must be signed in to change notification settings - Fork 146
Check white-space rules as part of Travis CI build #154
Check white-space rules as part of Travis CI build #154
Conversation
@@ -1,3 +1,4 @@ | |||
// KCR WAS HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinrushforth, is this comment intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I am testing the white-space checker (that particular line will fail because it has trailing white-space).
Note the "Experiment" label, meaning I am just running some tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the label....Thanks @kevinrushforth ..
- generate a list of files from a pull request and run checkWhiteSpace -x
@brcolow you might also want to take a look at this one. |
Very nice. Might take a stab at trying to do the same thing on Appveyor based on your work here. LGTM. |
I don't know that there is much value in duplicating this for the Windows build, since it would just be scanning the same set of source files. If you do want to look at doing that, you might need to skip the |
@muralibilla @tiainen @johanvos Can one of you review this when you get a chance? |
- generate a list of files from a pull request and run checkWhiteSpace -x
This is a fix for issue #108