Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Check white-space rules as part of Travis CI build #154

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Check white-space rules as part of Travis CI build #154

merged 1 commit into from
Aug 21, 2018

Conversation

kevinrushforth
Copy link
Collaborator

@kevinrushforth kevinrushforth commented Aug 11, 2018

This is a fix for issue #108

@kevinrushforth kevinrushforth self-assigned this Aug 11, 2018
@kevinrushforth kevinrushforth added enhancement New feature or request WIP Work In Progress Experiment Experimental changes, not intented for merge labels Aug 11, 2018
@@ -1,3 +1,4 @@
// KCR WAS HERE
Copy link

@muralibilla muralibilla Aug 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinrushforth, is this comment intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I am testing the white-space checker (that particular line will fail because it has trailing white-space).

Note the "Experiment" label, meaning I am just running some tests.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the label....Thanks @kevinrushforth ..

@kevinrushforth kevinrushforth changed the title [WIP] Automacially check white space as part of Travis CI build [WIP] Check white space as part of Travis CI build Aug 15, 2018
- generate a list of files from a pull request and run checkWhiteSpace -x
@kevinrushforth kevinrushforth changed the title [WIP] Check white space as part of Travis CI build Check white-space rules as part of Travis CI build Aug 15, 2018
@kevinrushforth kevinrushforth removed Experiment Experimental changes, not intented for merge WIP Work In Progress labels Aug 15, 2018
@kevinrushforth
Copy link
Collaborator Author

@brcolow you might also want to take a look at this one.

@brcolow
Copy link
Contributor

brcolow commented Aug 15, 2018

Very nice. Might take a stab at trying to do the same thing on Appveyor based on your work here. LGTM.

@kevinrushforth
Copy link
Collaborator Author

I don't know that there is much value in duplicating this for the Windows build, since it would just be scanning the same set of source files. If you do want to look at doing that, you might need to skip the -x option to checkWhiteSpace since that is unreliable on Windows (it works on some versions and gives false positives on others, so we typically don't do the check for executable files on Windows).

@kevinrushforth
Copy link
Collaborator Author

@muralibilla @tiainen @johanvos Can one of you review this when you get a chance?

@kevinrushforth kevinrushforth merged commit 9f09ddc into javafxports:develop Aug 21, 2018
@kevinrushforth kevinrushforth deleted the check-white-space branch August 21, 2018 14:49
kevinrushforth added a commit that referenced this pull request Aug 23, 2018
- generate a list of files from a pull request and run checkWhiteSpace -x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants