-
Notifications
You must be signed in to change notification settings - Fork 146
Add a powershell script for Windows dev, use on Appveyor. #153
Add a powershell script for Windows dev, use on Appveyor. #153
Conversation
@@ -0,0 +1,15 @@ | |||
choco install ant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be the first time a "github-only" file showed up in this directory. I'd like to limit the 'github-only' files to as few locations as possible. This raises an interesting question of whether these sort of build files should eventually be committed to the HG openjdk repo, in which case it wouldn't matter.
Pending that more global discussion, perhaps there is a better place to put it? In a new appveyor dir maybe? Not sure (would like to think about this for more time than I have today).
Maybe one of the Gluon folks have some thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a non-trivial question. In general, I am leaning towards separating code and build logic, since there might be multiple usages of the same source.
In this case however, the file is intended to be added for test purposes, hence I think it makes sense to do it here.
It is also not a github specific file, so I think it makes sense adding it to the hg repository as well.
In that case, I am OK with this as long as we can keep the changes that do not currently go back to the HG repo on OpenJDK (the This brings up a point I've been thinking about for a while. We really should eliminate (or at least minimize) any differences between the HG repo and the I'll file a JBS issue to consider unifying them. |
https://bugs.openjdk.java.net/browse/JDK-8209765 I maybe should not have mentioned the appveyor stuff, as that isn't in the upstream repo. But I don't think that extra verbiage should hurt anything. |
Thanks for filing the bug. That's fine about mentioning appveyor (I also added a comment for those looking at it indicating that the appveyor.yml file will be excluded from the openjfx/jfx-dev/rt changeset). I fixed up a couple things, assigned it to you, and linked it to this PR (by adding the Can you send a review request to openjfx-dev with a pointer to this PR so any other interested party can also review it? |
As long as the Appveyor build is passing with the new script, it looks fine to me. Edited to add: see below for one recommended change. |
tools/scripts/build.ps1
Outdated
$env:VS150COMNTOOLS = $env:VCINSTALLDIR | ||
$env:VSVARS32FILE = "$env:VCINSTALLDIR\vcvars32.bat" | ||
refreshenv | ||
.\gradlew all test -PCOMPILE_WEBKIT=false -PCONF=DebugNative --stacktrace -x :web:test --info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend adding --no-daemon
which was present in the appveyor.yml file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For CI builds I wanted to use --no-daemon
. For local builds it makes sense to use the daemon IMO. So in the latest commit we check if APPVEYOR
environment variable is set. If so, use --no-daemon
. Otherwise, don't. Is that okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I broke it, let me fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, strange, it seems that the downloading of OpenJDK 10 is what failed. Let me see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now. I'll merge it once the CI builds pass.
I see the following from the Appveyor log (looks like it is a dependency of ant), but it doesn't look like this is new:
In any event, it isn't using JDK 8, so it's not a problem. I'll merge the PR now. |
JDK-8209765: Add powershell build script for OpenJFX Reviewed-by: @kevinrushforth
The script
tools\scripts\build.ps1
works for locally building OpenJFX without any additional environment setup as long as one has the choco package manager installed. It automatically finds the location of the latest installed versions of Visual Studio and the Windows SDK and sets the necessary environment variables so that the gradle build works out-of-the-box without requiring somewhat tedious manual setup/configuration.