-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linux mips64el #827
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -947,6 +947,9 @@ else if (Platform.isARM()) { | |
cpu = "arm"; | ||
libc = "-gnueabi"; | ||
} | ||
else if (Platform.ARCH.equals("mips64el")) { | ||
libc = "-gnuabi64"; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I checked debian mips64el and there is also a different libc suffix: else if (Platform.ARCH.equals("mips64el")) {
libc = "-gnueabi64";
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I checked the path of libc.so for example, So on debian, I think you suggestion is correct. However, I think it should be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree with your assessment. I inserted a typo. |
||
|
||
return cpu + kernel + libc; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed, in the following line the property
jre.arch
is set toos.arch
and so no specialcase is needed here.