Exception from COMBindingBaseObject swallows real reason + HRESULT #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception thrown from COMBindingBaseObject when instatiation fails
is misleading:
COM object with CLSID {0002DF01-0000-0000-C000-000000000046} not registered properly!
In the concrete case COM was not properly initialized, the same error now
reports (in german locale):
CoInitialize wurde nicht aufgerufen.(HRESULT: 800401f0) (puArgErr=)
For english locale this should be along the lines of:
CoInitialize was not called.(HRESULT: 800401f0) (puArgErr=)
The message now points out the correct problem (as far as the windows
error code translation works) and the HRESULT can be used for a locale
independend report + search.
Closes java-native-access#646
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: We might have a lot of QuicheQuicChannel in memory so we should try to keep the memory usage as low as possible. Modifications: Grow long[] for readable streams and writable streams dynamically Result: Less memory usage when not a lot of streams are active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception thrown from COMBindingBaseObject when instatiation fails
is misleading:
COM object with CLSID {0002DF01-0000-0000-C000-000000000046} not registered properly!
In the concrete case COM was not properly initialized, the same error now
reports (in german locale):
CoInitialize wurde nicht aufgerufen.(HRESULT: 800401f0) (puArgErr=)
For english locale this should be along the lines of:
CoInitialize was not called.(HRESULT: 800401f0) (puArgErr=)
The message now points out the correct problem (as far as the windows
error code translation works) and the HRESULT can be used for a locale
independend report + search.
Closes #646
Please note: The change in COMBindingBaseObject looks worse in the diff, than it is. The two constructors (the clsid and the progid ones) were mostly duplicated code. The duplicate part was merged into the init method, and the constructors delegate to that method.