Implement SAFEARRAY access and bugfix VARIANT #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasblaesing
force-pushed
the
safearray
branch
from
e0e51c2 to
a58f930
Compare
| @@ -43,6 +43,7 @@ Features | |||
| * [#608](https://github.com/java-native-access/jna/pull/608): Mavenize the build process - change parent and native pom artifactId/name to differentiate in IDE and build tools. [@bhamail](https://github.com/bhamail) | |||
| * [#613](https://github.com/java-native-access/jna/pull/613): Make Win32Exception extend LastErrorException [@lgoldstein](https://github.com/lgoldstein). | |||
| * [#613](https://github.com/java-native-access/jna/pull/614): Added standard 'Kernel32Util#closeHandle' method that throws a Win32Exception if failed to close the handle [@lgoldstein](https://github.com/lgoldstein). | |||
| * [#618](https://github.com/java-native-access/jna/pull/618): Implement SAFEARRAY access and bugfix VARIANT [@matthiasblaesing](https://github.com/matthiasblaesing) | |||
There was a problem hiding this comment.
Missing period again. The fact that this is the only problem I find says a lot ;)
|
This is nice work, also maybe @lgoldstein can take a look? |
matthiasblaesing
force-pushed
the
safearray
branch
from
a58f930 to
8580954
Compare
|
The CHANGES.md entry was adjusted - is there any way I can help with review? |
|
Rebase and squash it. I'll take a look again. |
matthiasblaesing
force-pushed
the
safearray
branch
from
8580954 to
6f802b8
Compare
- Bind more functions from OleAut32.dll - Fix bug in function bindings from OleAut32.dll (long vs. LONG) - Ensure SAFEARRAY.rgsabound is completely accessible - Modify Variant#getValue and Variant#setValue to allow flexible access to data - Add object oriented helper methods to SAFEARRAY and move functionality from limited methods in OleAutoUtil to SAFEARRAY - Add unittests based on windows search provider that excercise SAFEARRAY functions - Added a helper for optimized conversion from SAFEARRAY to Object[] Closes java-native-access#522
matthiasblaesing
force-pushed
the
safearray
branch
from
6f802b8 to
57bf211
Compare
|
I rebased the changeset onto latest master. For the request to squash the commits - this won't help with review and will destroy the logical structure. The commits are each focused on area:
If forced I will squash these, but I don't see benefit from that. |
|
Merged. |
mstyura
pushed a commit
to mstyura/jna
that referenced
this pull request
Sep 9, 2024
Motivation: How we used QuicConnectEvent to notify about connection migration was not correct at all. Let's remove it for now as we will introduce something better once cloudflare/quiche#1660 was merged into quiche. Modifications: Remove QuicConnectEvent Result: Get rid of incorrect implementation to prepare for adding a proper one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for details.