Small COM fixes #373
Merged
Small COM fixes #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Can you update from master, which should fix the CI issues? |
|
os x travis build seems to be stuck(?), linux went through ok. Somewhat hard to see how these could break the os x one. |
|
Thanks, this is great, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ComUtils was unable to enumerate classes without admin rights because it tried to open the registry keys with ALL_ACCESS instead of READ_ACCESS.
COMBindingBaseObject was using CoInitialize instead of CoInitializeEx, however MSDN recommends "New applications should call CoInitializeEx instead of CoInitialize. If you want to use the Windows Runtime, you must call Windows::Foundation::Initialize instead."
COMBindingBaseObject was also interpreting S_FALSE as "CoInitialize failed" instead of "CoInitialize has already been called" and failing randomly.