Added Win32 Monitor Configuration API and demo

[msteiger]

This adds the Windows Monitor Configuration API methods and structures. I tested the port with a small monitor demo which is also part of this PR. It enumerates all monitors and displays their caps.

[dblock]

Please follow the syntax of other CHANGELOG entries, copy from above. Thx.

[dblock]

This is good work. However, all these new functions need tests to be merged. A demo is not good enough :)

Minor: I am not convinced FlagEnum and EnumConverter should live where they are, I am worried that .platform becomes a repository for utility functions. Not sure where it should go. The class itself needs its own tests.

Something with tabs/spaces that looks off, there's a lot of them and things are aligned the same way. Maybe run some automatic formatter on this? Would be nice to fix.

[msteiger]

Thanks - I updated the PR:

• Fixed typo
• Updated CHANGES.MD
• Fixed whitespace/tabs
• Added tests in User32Test
• Created Dxva2Test test case - also tests EnumConverter and EnumUtils (not sure how to test them independently)

[dblock]

Can we assert something in this test? For example that you have at least one monitor? Then, each one of the Dxva functions should also be an actual test. For example, GetMonitorCapabilities returns some values in temps and caps, assert that they are not 0 for example.

[msteiger]

I split the tests into smaller ones and added asserts where possible.
Please note that the test case will succeed only if at least one monitor is attached - i.e. not on a build server.

[dblock]

Good work. Merged via bf870bb (you might want to squash your own commits, I try to keep things tidier on merge).

[msteiger]

Thanks! I would throw out my master branch and create a new from yours. Should have the same effect, right?

[dblock]

You should definitely reset your master to the upstream master, first. I usually do this by doing a git reset --hard a few commits back, then git pull upstream master, then a force push of git push origin master -f. (If you have changes on master that need to be saved first, git checkout -b some-new-branch, then git checkout master first).

I always work on branches. When I make small changes, I git commit --amend them, sometimes force push. No fear :)

[wolftobias]

PLease let me understand the background of your mail. I`m I using a outdated code base? I just want to avoid overwriting my changes.
 

Gesendet: Montag, 26. Mai 2014 um 12:58 UhrVon: "Daniel Doubrovkine (dB.) @dblockdotorg" [email protected]: twall/jna [email protected]: Re: [jna] Added Win32 Monitor Configuration API and demo (#332)

You should definitely reset your master to the upstream master, first. I usually do this by doing a git reset --hard a few commits back, then git pull upstream master, then a force push of git push origin master -f. (If you have changes on master that need to be saved first, git checkout -b some-new-branch, then git checkout master first).

I always work on branches. When I make small changes, I git commit --amend them, sometimes force push. No fear :)

—
Reply to this email directly or view it on GitHub.

[wolftobias]

@dblock Are you sure you are meaning me? I`ve not commited this commit request. Please let me know if there was a mistake.

[dblock]

I meant this for @msteiger.

[msteiger]

I think I figured it out - thanks!

[dblock]

I'm seeing this on my box now after this PR was merged:

    [javac] Compiling 24 source files to c:\Users\dblock\source\jna\twall\contrib\platform\build\classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] c:\Users\dblock\source\jna\twall\contrib\platform\src\com\sun\jna\platform\win32\Dxva2.java:51: error: diamo
nd operator is not supported in -source 1.5
    [javac]                         addTypeConverter(MC_POSITION_TYPE.class, new EnumConverter<>(MC_POSITION_TYPE.class)
);
    [javac]                                                                                    ^
    [javac]   (use -source 7 or higher to enable diamond operator)
    [javac] 1 error
    [javac] 1 warning

[dblock]

Fixed in de798fd.

[dblock]

I added 1c7e616 which will skip the tests when there's no physical monitor attached, @msteiger check the code please I am not sure this is the best way. Feel free to PR updates.