Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace StringBuffers with StringBuilders #291

Merged
merged 1 commit into from
Nov 15, 2013
Merged

Replace StringBuffers with StringBuilders #291

merged 1 commit into from
Nov 15, 2013

Conversation

ebourg
Copy link
Contributor

@ebourg ebourg commented Nov 15, 2013

Here is a trivial patch replacing the private StringBuffers with non synchronized StringBuilders. This doesn't affect the StringBuffers exposed by the public API.

@dblock
Copy link
Member

dblock commented Nov 15, 2013

@ebourg I am sure it's a good idea, but could you explain why? Thanks :)

@ebourg
Copy link
Contributor Author

ebourg commented Nov 15, 2013

This is just a minor performance improvement, because the methods of StringBuilder aren't synchronized like StringBuffer.

http://stackoverflow.com/questions/355089/stringbuilder-and-stringbuffer-in-java

dblock added a commit that referenced this pull request Nov 15, 2013
Replace StringBuffers with StringBuilders
@dblock dblock merged commit e736b45 into java-native-access:master Nov 15, 2013
@dblock
Copy link
Member

dblock commented Nov 15, 2013

Merged, thx.

mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…ive-access#291)


Motivation:

Quiche changed its API to be network path aware and so be able to handle connection migration in the future.

Modifications:

- Adjust code to use the new API

Result:

Be able to use the new network-path aware API of quiche
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants