-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of function SHAppBarMessage from ShellApi #245
Conversation
It's a good start, thank you. A few things:
|
You absolutely right.. i've worked so fast and, as consequence, have missed these important details Probably my test was more a kind of demo rather unit test thx for feedbacks ... i'll working on |
javadoc refactoring unit test refactoring CHANGES.md update
@@ -7,6 +7,7 @@ NOTE: JNI native support is typically incompatible between minor versions, and a | |||
|
|||
Features | |||
-------- | |||
* [#241](https://github.com/twall/jna/issues/241) - Add support function SHAppBarMessage from ShellApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add your name, similar to the other items below.
You have to merge from upstream, otherwise this looks good to go. |
Ok, thanks for feedbacks Don't worry, indeed sorry for the problems of code formatting but from my ide (eclipse on mac) all seemed good i'll go to merge and fix, hoping that my little work will become part of next release of this great project |
Sorry to be annoying, click on the files changed diff here. The changelog is completely reformatted spaces/tabs. That will make history unusable. Could you please fix that? I would take the original file, use notepad or something to edit it. LMK if you can't figure it out and I'll do it by cherry-picking your changes. |
Again don't worry Since the great part of problems seems relates to code formatting and they are increasing .... what do you think whether i send you the (only) three updated files and you put directly on your branch ? i'll provide to make a fresh fork to avoid problem for the future |
Merged via e0d2079. You should be able to reset your master branch to an older commit, eg |
Thx for useful feedbacks. Don't worry i love to contribute to the project and i'll go ahead i'll follow your suggestion ... hoping, next time, will go better |
i've implemented what i asked in Issue #241
I've tested all the stuff on Windows 7 x64