Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make handle volatile to ensure safe publication #1561

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/com/sun/jna/NativeLibrary.java
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public long getSymbolAddress(long handle, String name, SymbolProvider parent) {
};

private Cleaner.Cleanable cleanable;
private long handle;
private volatile long handle;
private final String libraryName;
private final String libraryPath;
private final Map<String, Function> functions = new HashMap<String, Function>();
Expand Down Expand Up @@ -1055,7 +1055,7 @@ private static ArrayList<String> getLinuxLdPaths() {

private static final class NativeLibraryDisposer implements Runnable {

private long handle;
private volatile long handle;

public NativeLibraryDisposer(long handle) {
this.handle = handle;
Expand Down