Be more explicit, that contributions are expected to follow code conventions #1458
Conversation
| @@ -7,7 +7,10 @@ JNA contains work from many developers. You're encouraged to contribute to both | |||
| - Fork the code from [github.com/java-native-access/jna](https://github.com/java-native-access/jna) | |||
| - Check out the code with `git clone [email protected]:username/jna.git` | |||
| - Ensure you can build the project with `ant dist test test-platform` | |||
| - Make your code changes, write tests, build | |||
| - Make your code changes, write tests, build. New code should follow the | |||
| conventions observable in the surrounding code/the codebase. Existing code | |||
There was a problem hiding this comment.
Could you please explicitly state the conventions you want, for example "Traditional Bean Java Naming conventions". Otherwise you're asking for an undefined Standard, as there is no declared linter, nor linting test within the Testing Pipeline.
|
No - I will not. IMHO it is the job of the reviewers to ensure consistency. I will not put time into specifying it down to the exact specification, else we will get the next discussion. I'll enforce consistency by just fixing it myself it is to much to ask contributors. |
|
I think I can write up a happy medium that does not define explicit formats (that we are a decade too late enforcing) but summarizes some of the unwritten rules to give contributors nonzero guidance. |
No description provided.