-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix IOKitTest for M1 compatibility #1420
Conversation
Thank you for the update. The test system I currently have available still fails though. I get this:
If I update that check to: assertTrue(controllerName.startsWith("AppleUSB") || controllerName.startsWith("usb-drd1")); I hit the next wall:
I have to see whether I can learn enough about the structure and have a go myself. I think this is a bit like #1419, if you have acccess and a feeling where to look, it becomes easy, but if you are missing either, you poke in the dark. |
There's a tool "IORegistryExplorer" if you have desktop access. For ssh, the command line to "explore" is Looking back at the reported issue I can see the "controller name" as you are seeing and should have double-checked that with my "fix", but it also appears the "class name" of the root hub simulation is no longer "IOUSBDevice" which I didn't test for. It might be that rather than skipping the test, we just don't make assumptions about names. We're really testing the parent/child and non-null should be good enough.
|
(I'm thinking it would work if we restricted the child search to controllers beginning "pci" but also I think just removing the name check would work.) |
Based on your suggestion (to focus on the relationship) I pushed an updated version into #1419 and also ensured that appveyor is happy again. Could you have another look there? |
LGTM! |
Fixes test failure reported in #1419