Add CertOpenStore to c.s.j.p.win32.Crypt32 #1418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contrib/platform/test/com/sun/jna/platform/win32/Crypt32Test.java
Outdated
Show resolved
Hide resolved
contrib/platform/test/com/sun/jna/platform/win32/Crypt32Test.java
Outdated
Show resolved
Hide resolved
| @@ -43,6 +43,63 @@ | |||
|
|
|||
| Crypt32 INSTANCE = Native.load("Crypt32", Crypt32.class, W32APIOptions.DEFAULT_OPTIONS); | |||
|
|
|||
| // Store providers for CertOpenStore | |||
There was a problem hiding this comment.
This should go into WinCrypt.java as definition comes from WinCrypt.h. The two encoding definitions are already there.
There was a problem hiding this comment.
The new constants should still be moved to WinCrypt.java. As CertStoreProviderName is not from a header it is debatable, but I would also move it.
There was a problem hiding this comment.
Done. I did not add a javadoc to each of them, from MSDN page it looks like a lot of text with references and we probably don't want to have it all copied to WinCrypt
contrib/platform/test/com/sun/jna/platform/win32/Crypt32Test.java
Outdated
Show resolved
Hide resolved
…or CertOpenStore
…nts to WinCrypt
|
Merged via af8458b. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.