Do not throw Win32Exception on success for empty section in Kernel32Util#getPrivateProfileSection #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks sane to me. Thank you. I would not have pulled out the empty array creation as filling the heap is kind of helpful for JNA (memory freeing is tied to GC), but I see the idea. Would you please
Thank you. btw: there is no need to open issues, if you want to directly fix them. A PR is enough :-) |
dbwiddis
changed the title
in Kernel32Util#getPrivateProfileSection
dbwiddis
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1410
Apparently what the caller in such a situation expects is to get the content of the existing section, i. e. an empty String array.
Using a constant object to reduce heap pollution.