-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RegLoadAppKeyW #1377
Add RegLoadAppKeyW #1377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - looks sane to me. I left an inline comment about the naming of the function and please remove the darwin-aarch64.jar
.
And one additional request: Please add a feature entry for the newly bound function in CHANGES.md
.
b741bbb
to
96965e7
Compare
@matthiasblaesing Do I need to add the registryLoadAppKey method in |
I would mention both. If space is an issue the prefix |
96965e7
to
7deb1e0
Compare
@matthiasblaesing, it is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good. Last change request: Please rebase the changes onto current master. Sunday night the 5.9.0 release was cut. The git diff does not recognize the merge conflict, but it needs to be resolved (merging as is would add the change description to 5.9.0, but it will become part of 5.10.0).
7deb1e0
to
17a3960
Compare
Sorry, the |
17a3960
to
5fc5ce4
Compare
5fc5ce4
to
0d12f2c
Compare
@matthiasblaesing I misunderstand it, sorry. I updated CHANGES.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you.
Also, fix source compatibility with Java 6. It blocks my local test run.