Prevent illegal access exceptions, when retrieving options for private library interfaces with an instance field #1284
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System info
JNA encounters
IllegalAccessException
s, when trying to retrieve library options fromprivate
Library
interfaces that contain an instance field. Since direct mapped classes may retrieve options for the first time, only when a callback is passed or returned, this can happen rather unexpectedly.This change suppresses the
IllegalAccessException
s by callingsetAccessible
like it is already done, when looking up other fields of the library interface via reflection.Example stack traces (see
PrivateLibraryInfoTest.java
andPrivateDirectCallbacksTest.java
)