Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Wincon bindings #1194

Closed
wants to merge 2 commits into from
Closed

Add additional Wincon bindings #1194

wants to merge 2 commits into from

Conversation

rednoah
Copy link
Contributor

@rednoah rednoah commented May 16, 2020

Add additional Wincon bindings:

  • GetConsoleScreenBufferInfo
  • ReadConsoleInput
  • WriteConsole

@rednoah
Add additional Wincon bindings:
8869d29 
* GetConsoleScreenBufferInfo
* ReadConsoleInput
* WriteConsole
@rednoah rednoah mentioned this pull request May 16, 2020
Closed
@matthiasblaesing
Copy link
Member

I think the only issue I see is, that the structures don't belong into WinDef.java but should be in Wincon.java.

@matthiasblaesing
Copy link
Member

Merged via b22f85a. Thank you.

fixed the PR to be mergeable:

  • there was no CHANGES.md entry
  • the unittest could not have worked and indeed failed on travis, because the imports were from the wrong class

@rednoah
Copy link
Contributor Author

rednoah commented May 18, 2020

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rednoah @matthiasblaesing