Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows expects Unicode String for IShellFolder#ParseDisplayName #1127

Merged
merged 2 commits into from
Aug 18, 2019

Conversation

dbwiddis
Copy link
Contributor

IShellFolder#ParseDisplayName third argument requires a null-terminated wide string in Windows but is mapped as a String. Initial commit is failing testcase.

@dbwiddis dbwiddis marked this pull request as ready for review August 16, 2019 22:30
@dbwiddis
Copy link
Contributor Author

Testcase now passes after the fix.

Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Should this be squashed? If so, it is good to go as-is, if not, I'd like to ask you to recheck the author information. In general I think the author information should always contain the full name and a valid emailadress. Your "realname" part is a truncated version of your fullname, but can be considered ok, but in the commits e84d355 and e578437 even the email part does not look valid. Please check your git settings and ensure, that the realname and email parts are filled correctly. If you decide, that this should not be squashed, please update the commits with the correct author information.

Thank you.

@dbwiddis
Copy link
Contributor Author

dbwiddis commented Aug 18, 2019

It can be squashed, I only separated the commits in case a reviewer wanted to verify the testcase. But I fixed the author information anyway.

@matthiasblaesing matthiasblaesing merged commit cdad205 into java-native-access:master Aug 18, 2019
@matthiasblaesing
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants