Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetLogicalProcessorInformationEx function #1064

Closed
wants to merge 3 commits into from

Conversation

dbwiddis
Copy link
Contributor

@dbwiddis dbwiddis commented Feb 4, 2019

Tested on Windows Server 2016 with 80 logical cores (successfully read 2-element group relationship array) as well as 32-bit Win7 and 64-bit Win10. Further discussion on JNA mailing list.

Copy link
Member

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I left two comments inline. Thank you.

CHANGES.md Show resolved Hide resolved
@@ -941,7 +986,6 @@ public static final String QueryFullProcessImageName(HANDLE hProcess, int dwFlag

WinBase.EnumResTypeProc ertp = new WinBase.EnumResTypeProc() {

@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for removing the @OverRide annotations? These are valid overrides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE flagged this as an error, and stubbornly wouldn't format my other code until I eliminated the errors.

Turns out I had my compiler level on my JNA project set to 1.5 (where this was disallowed). I've switched it to 1.6. I'll put those overrides back.

@matthiasblaesing
Copy link
Member

Merged via e0d5537. I widened the method signature from Memory´ to Pointer`, that allows later to use other pointer based implementations.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants