Implement binding for extended file attributes handling on Linux. #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you for your work. I did a first pass over the code and left comments inline.
You choose to base your work on 4.5.X. I left that branch as a pure bugfix branch. Feature work should go into master. I already checked - your changes apply cleanly onto master.
| int lsetxattr(String path, String name, Pointer value, size_t size, int flags); | ||
| int fsetxattr(int fd, String name, Pointer value, size_t size, int flags); | ||
|
|
||
| ssize_t getxattr(String path, String name, Pointer value, size_t size); |
There was a problem hiding this comment.
In XAttrUtil you convert Memory <-> byte[]. You could add overloads here, that take byte[] in addition to pointer - I can see use-cases for both calls:
ssize_t getxattr(String path, String name, Pointer value, size_t size);
ssize_t getxattr(String path, String name, byte[] value, size_t size);There was a problem hiding this comment.
I can see why it would be convenient to have such overload. But I do not understand if JNA will then apply the right conversion to handle the byte[] automatically. Does it?
|
Closing in favor of #1021 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.