Memory.dispose() does not remove "this" from the allocatedMemory map

[AgnetaWalterscheidt]

Method Memory.dispose() frees the peer and sets it to 0. Afterwards it calls allocatedMemory.remove(this). This call does not find the Memory in the map: Memory is a subclass of Pointer which uses the peer for hashcode() and equals() and therefore "this" is no longer equal to the Memory that was put in the map.
This bug is easy to fix by first calling allocatedMemory.remove(this) and then setting the peer to 0.

[twall]

Good catch. Could you provide a PR with the fix and an associated test?

On Tue, Aug 30, 2016 at 3:33 AM, AgnetaWalterscheidt <
[email protected]> wrote:

Method Memory.dispose() frees the peer and sets it to 0. Afterwards it
calls allocatedMemory.remove(this). This call does not find the Memory in
the map: Memory is a subclass of Pointer which uses the peer for hashcode()
and equals() and therefore "this" is no longer equal to the Memory that was
put in the map.
This bug is easy to fix by first calling allocatedMemory.remove(this) and
then setting the peer to 0.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#697, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAuMrTUjJYafXGniw4wqiEDHC1hud0XGks5qk9y0gaJpZM4JwOmU
.